Fix dangling pointer access in main output #920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After OBS Studio has reset its video output, the NDI main output still held a pointer to the old video output and tried to access it when starting the NDI main output. To avoid the dangling pointer access, defer allocation of the NDI main output context.
ba27994 to
4aeb4ae
Compare
paulpv
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR defers the allocation of the NDI main output context.
Fix #908
Motivation and Context
After OBS Studio has reset its video output, the NDI main output still held a pointer to the old video output and tried to access it when starting the NDI main output.
How Has This Been Tested?
OS: Fedora 37
I followed the steps described in the issue #908 and confirmed it crashed without this PR but does not crash with this PR.
Types of changes