Skip to content

Conversation

@BitRate27
Copy link
Contributor

Uninstall and directly remove DistroAV 6.0.0 files from the old Program Files location.

Starting with DistroAV 6.1.0, we now install DistroAV in OBS's ProgramData folder. This means the old install in Program Files is not removed/updated to the new version. This results in the plugin showing up twice in the Tools pulldown, and also unclear which is used for NDI sources.

To fix this we uninstall DistroAV 6.0.0 by finding the uninstall exe and running it. We also remove any files that may have been installed manually from the OBS's Program Files folder.

This is not a selectable task like the obs-ndi plugin removal.

This fixes issue #1290

@BitRate27 BitRate27 requested a review from Trouffman June 11, 2025 12:08
@Trouffman
Copy link
Collaborator

This will not work as it is today.

Reason :

  • The uninstall is called at the end of the installation of DistroAV. The uninstall is targeting the AppID, BUT 6.0.0 and 6.1.0 share the same ID.
    That means : The installer will install 6.1.0, then delete 6.1.0. leaving 6.0.0 intact & removing 6.1.0.

We should uninstall 6.0.0 as a "pre-install" step (via uninstaller).
However, it is fine to keep the "files clean-up" (removing the files directly) as a "post-install" step.

While digging into this I found out that DistroAV 6.1.0 doe snot set the proper registry key (which is why this might have worked for you without issue).

We now have 2 issues to fix :

  • 6.0.0 is not uninstalled
  • 6.1.0 is not installed properly on Windows Registry (Key is {}_is1)

Add fucntion to check version installed
Execute uninstall of previous version before installation (required)
Use static link to Registry path
Add 6.1.0 registry check for instalations error
Add a proper app Name for Uninstall entry in Windows.
@Trouffman
Copy link
Collaborator

Tested as follow:

  • DistroAV 6.0.0 installed
  • DistroAV 6.1.0 installed

Run This PR Installer with /LOG flag.

Detection of 6.0.0 & 6.1.0 works, Uninstall return code 0 (success)

2025-06-11 18:08:36.565   DistroAV plugin version already installed detected : 6.0.0...
2025-06-11 18:08:36.565   Uninstalling previous DistroAV plugin version...
2025-06-11 18:08:36.767   Uninstall previous DistroAV return code: 0
2025-06-11 18:08:36.767   Uninstalling previous DistroAV plugin version 6.1.0...
2025-06-11 18:08:36.947   Uninstall previous DistroAV return code: 0
2025-06-11 18:08:36.947   Starting the installation process.

Confirmed that

  • 6.1.0 - Registry entry is gone
  • 6.1.0 files are removed as well

Issue :

  • 6.0.0 - Registry entry is gone (not supposed to)

  • A new entry in registry is "FF773A8D-7648-4630-8155-3D5190CDF785" - Expected to be "{FF773A8D-7648-4630-8155-3D5190CDF785}".

@Trouffman
Copy link
Collaborator

Good outcome, it now look cleaner in the Uninstall list :
image

@Trouffman
Copy link
Collaborator

Trouffman commented Jun 11, 2025

The latest commit before this message fix the {{APPID}} issue.

But brings to light that the Setup WILL use the previous Directory.

This can be fixed with : UsePreviousAppDir=no (default is yes) and this will not try to use the previous install location.

@Trouffman Trouffman merged commit eb4d04b into DistroAV:master Jun 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants