Disable the debug log print of audio / Video Frame as this is too tal… #1254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR disables the debug log prints in the NDI source thread to reduce excessive logging and improve performance in production.
- Commented out debug logging for new audio/video frames (both when framesync is ON and OFF).
- Ensures that only development-level debugging remains accessible while production logs remain cleaner.
…kative. This logging level was making the log unusable for release.
e984897 to
bdf6533
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable the debug log print of audio / Video Frame as this is too talkative and slow performances.
Initial reason to add this to master might have been overlooked. (by me...)
This create too much noise in the log file and makes it unsuable.
The possible implementation by @BitRate27 from #1185 might be more suitable on the long-run.
This PR only aim to comment out the log entry, it is there for dev-debug purpose but should not be enable in production/release.
Comment & Arguments are welcome.