Fix OBS Source (temporary) with upstream fix not released yet. #1252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Revert this to use obsproject/obs-studio for release tagged after 31.0.3.
BitRate27
approved these changes
Apr 23, 2025
Contributor
BitRate27
left a comment
There was a problem hiding this comment.
Confirmed the tag on our obs-studio fork exists, and saw the temporary changes there. Doesn't appear to need an approval there as it is a straight commit/tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Revert this to use obsproject/obs-studio for release tagged after 31.0.0.
Important :
obs-plugintemplatewhen the fix (macos SDK detection) is available in a tagged release.31.0.3tag.obs-studioOBS Project.This fix solves:
What has been done :
cmake: Adjust macOS SDK detection obsproject/obs-studio#11893
Also similar to :
obsproject/obs-studio#12076
IMPORTANT
This is an exceptional & temporary change to allow the project to create new releases.
This MUST be reverted to the proper Obs upstream buildspec as soon as the obs-plugin-template implement the required changes.