Skip to content

Fix the NDI Preview Output issue introduced in 1198 #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Trouffman merged 2 commits into from
Apr 1, 2025
Merged

Fix the NDI Preview Output issue introduced in 1198 #1237

Trouffman merged 2 commits into from
Apr 1, 2025

Conversation

@Trouffman
Copy link
Collaborator

@Trouffman Trouffman commented Mar 31, 2025

This PR address the following :

How this fix the problem ?

  • The Preview-output.cpp was not, modified to reflect the changes integrated in main-output.cpp

General hope is that the 2 codebase are extremely similar (with some extra code in Preview for specifics in there)

This bring the codebase to be similar for the approach & logic on both Main output and Preview output

@Trouffman
Fix the NDI Preview Output to be closer to the Main Output code. Add …
fb34188 
…specific log entries for easier debuggging on outpu settings
@Trouffman
Update formating
028ddd0
@Trouffman Trouffman added Seeking Testers PRs with this label will package the plugin so that others can test Interface (UI/UX) User Interface (UI / GUI) or User Experience (UX) Output (Program/Preview) relate to NDI Output Progam or Preview labels Mar 31, 2025
@Trouffman Trouffman mentioned this pull request Mar 31, 2025
Merged
@BitRate27
Copy link
Contributor

BitRate27 commented Mar 31, 2025 •
edited by Trouffman
Loading

Mod Edit : this is not related to the PR : See reason at : #1237 (comment)

It looks like your changes are indeed needed as they are the exact changes I made to PR 1148 a couple of days ago. However, I still do not get any preview output when I run this PR on the latest master branch from obs-studio. I can select the NDI preview output in Studio Monitor, but there is no video feed. When I change to another preview scene, the NDI preview output in Studio Monitor does not change. Please let me know if you have trouble duplicating this issue.

  1. Get into Studio Mode
  2. In Tools->DistroAV NDI Settings, check Preview Output
  3. Enter "OBS Preview" for the name
  4. Select OK
  5. Open NDI Studio Monitor
  6. Select your local machine, and select "OBS Preview" (this being available is indicative of the NDI sender being created)
  7. Error 1: the display does not change and does not match what is shown in the Preview window in OBS
  8. In OBS select another scene
  9. Error 2: the display does not change and does not match what is shown in the Preview window in OBS

BitRate27
BitRate27 approved these changes Apr 1, 2025
View reviewed changes
Copy link
Contributor

@BitRate27 BitRate27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this last change by:

  1. turning off main output, changing video resolution in settings, turning main back on.
  2. turning off main output, changing color format in settings, , turning main back on.
  3. changing profiles without turning off main output.
  4. Used empty Main Output and Preview Output names.
    No longer crashes on changes!

@Trouffman
Copy link
Collaborator Author

Trouffman commented Apr 1, 2025

Can you confirm that your initial reply in this thread was only when using the latest master branch of OBS ?

@BitRate27
Copy link
Contributor

BitRate27 commented Apr 1, 2025

The issue with preview output mentioned above was only seen with the master branch of obs-studio cloned on March 31, 2025. I did not see the issue and verified this PR by installing the .dll generated in the CI actions, on the 31.0.3 release of OBS Studio.

@Trouffman Trouffman merged commit 5fd1e50 into master Apr 1, 2025
6 checks passed
@Trouffman Trouffman deleted the fix-preview-output branch April 1, 2025 12:44
@Trouffman Trouffman mentioned this pull request Apr 2, 2025
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BitRate27 BitRate27 BitRate27 approved these changes

Assignees

No one assigned

Labels

Interface (UI/UX) User Interface (UI / GUI) or User Experience (UX) Output (Program/Preview) relate to NDI Output Progam or Preview Seeking Testers PRs with this label will package the plugin so that others can test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Trouffman @BitRate27