Upgrade to use audio_frame v3 instead of deprecated v2 #1175
Conversation
Add logging fro timestamps & Timecode Force timecode to be provided by the NDI lib instead of hardcoded in plugin + unifiy usage accross recv/sender Update filter audio to v3
|
Looking at the historical changes for this piece of code and how the "video_frame.timecode" is set I found that:
Great summary PR #564 To confirm : why was this reverted... |
Since I run so many NDI filter sources I can test it today. Edit: Initial tests with the filters show no issues. I'll see if I can arrange a 2-3 hour test with them soon enough |
|
Minor suggestion is to remove the audio_frame2 variable from the ndi_source_thread since it is no longer used. Might as well remove the ndi_source_thread_process_audio2 function also. Would also be nice to remove the 3 from the end of all remaining variable and function names as the designation is no longer needed. |
Renamed audio_fram3 >> audio_frame and video_frame2 >> video_frame to avoid confusion and simplify code
|
This should be "complete". I haven't experienced any issue with it since last commit. Used on Mac & windows. |
|
So far it's been fine. Should push IMO |
Add logging for timestamps & Timecode
Force timecode to be provided by the NDI lib instead of hardcoded in plugin
Unifiy usage accross recv/sender
Update filter audio to v3
Force FrameSync to use Audio_frame v3 instead of v2.
This is not really supposed to fix any specific bugs, but should help to keep the codebase up to date.
I have tested locally, but I do not use the NDI Filter that much so could be missing some things.
Things to test :