-
-
Notifications
You must be signed in to change notification settings - Fork 419
Use new obs_frontend_get_*_config APIs for OBS 31 #1152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new obs_frontend_get_*_config APIs for OBS 31 #1152
Conversation
This properly splits settings for this plugin into the new split configuration stores for app and user settings. All user-editable settings go into the user store, all functional, non-user facing settings go in app store (e.g. timestamp of last update check). On OBS versions prior to 31 there is no change in behaviour and all settings continue to be read from and stored to the global store only. Signed-off-by: Felix Kaechele <felix@kaechele.ca>
|
Thanks for putting this together. I liked how you separated the user from the app settings. Makes total sense. Only issue is that I was not able to build DistroAV with the LIBOBS_API_MAJOR_VER >= 31, so I was not able to test it. I was able to build and test with the < 31 condition and verified settings are preserved. So the code still works with old OBS includes and I still got the deprecated messages in the log when running with 31 dlls. |
|
Thanks. For what it's worth, I was building and testing this on Fedora 41, where the version of OBS available is currently For preexisting profiles the settings in |
Signed-off-by: Felix Kaechele <felix@kaechele.ca>
|
Took a first stab at a migration functionality. Works fine in my testing here, but I'd certainly appreciate some more testing.
If everything worked your original settings from |
|
Thank you for this change proposal. |
|
Merging things from the updated OBS Plugin Template for OBS 31 "base". Due to limited feedback from PR submitter, will try to continue from this to a workable solution. |
|
Update to some concerns in this PR : PARAM_SKIP_UPDATE_VERSION The other elements are not influenced / presented to the User and will be in the App Config: This is based on the commit infos :obsproject/obs-studio@2635cf3 |
|
While digging to update the plugin i foudn out that the check with LIBOBS_API_MAJOR_VER will only check at compile time and not Runtime. if we want to make the plugin backward compatible we will need to either expand on obs_get_version or simply drop this complexity and make OBS 31 a requirement. |
|
As we made OBS 31 a full requirement for DistroAV 6.1 this can be revisited and simplified. |
This properly splits settings for this plugin into the new split configuration stores for app and user settings.
All user-editable settings go into the user store, all functional, non-user facing settings go in app store (e.g. timestamp of last update check).
On OBS versions prior to 31 there is no change in behaviour and all settings continue to be read from and stored to the global store only.
Fixes #1121