Skip to content

Conversation

@Trouffman
Copy link
Collaborator

This adds a log entry with the exact path to the old OBS-NDI plugin file to help with diagnosing support request for issues like "DistroAV still detect OBS-NDI".

The message to look for in the OBS log is :

DistroAV] is_module_found: `obs-ndi` found at `/Users/[USER]/Library/Application Support/obs-studio/plugins/obs-ndi.plugin/Contents/MacOS/obs-ndi` and '/Users/[USER]/Library/Application Support/obs-studio/plugins/obs-ndi.plugin/Contents/Resources'
[DistroAV] obs_module_load: OBS-NDI is detected and needs to be uninstalled before DistroAV will load.

This should then help in the Troubleshooting guide as well : https://github.com/DistroAV/DistroAV/wiki/OBS%E2%80%90NDI-Is-Now-DistroAV

@Trouffman Trouffman changed the base branch from master to develop November 8, 2024 20:29
@paulpv
Copy link
Member

paulpv commented Nov 10, 2024

I have a similar change for this that I haven't committed yet:
image

I also want to change the installer display name (from distroav to DistroAV):
image

@Trouffman
Copy link
Collaborator Author

Latest commit teste and output expected result.
image

@paulpv
Copy link
Member

paulpv commented Nov 12, 2024

Latest commit teste and output expected result. image

Yeah, that is what I am a little worried about.
I am not very worried, but I would prefer to not just post people's names into OBS logs that are on the internet.
I think that might even violate some privacy laws. :/
Software is complicated nowadays beyond just the code. :/

Did you run this with any command-line arguments (ex: --distroav-debug), or none?

@paulpv
Copy link
Member

paulpv commented Nov 12, 2024

One option is to change the LOG_INFO to LOG_DEBUG, but then that would require someone to enter --distroav-debug on the command-line, which very few people will do.

Another option is to redact the username, but redacting the path almost defeats the purpose of printing out the path.

@Trouffman
Copy link
Collaborator Author

Latest commit teste and output expected result. image

Yeah, that is what I am a little worried about. I am not very worried, but I would prefer to not just post people's names into OBS logs that are on the internet. I think that might even violate some privacy laws. :/ Software is complicated nowadays beyond just the code. :/

Did you run this with any command-line arguments (ex: --distroav-debug), or none?

This was run as-is without the debug argument.

I am not keen on having the user folder as well being displayed.

@paulpv
Copy link
Member

paulpv commented Nov 13, 2024

I am not keen on having the user folder as well being displayed.

We could just programmatically redact it to say something like:

/Users/$USER/Library/Application\ Support/obs-studio/plugins/obs-ndi.plugin/

That seems both safe and still usable.

@Trouffman
Copy link
Collaborator Author

Added a filter for privacy.
Not ideal.

Tested on MacOS :

is_module_found: obs-ndifound at[Redacted User Home Path]/Library/Application Support/obs-studio/plugins/obs-ndi.plugin/Contents/MacOS/obs-ndi`

Using DEBUG log-level will still display the full path.

@Trouffman Trouffman requested a review from paulpv November 17, 2024 03:34
@Trouffman
Copy link
Collaborator Author

@paulpv Please review the latest changes to add some privacy to the path.

@Trouffman Trouffman merged commit af2fa06 into develop Dec 22, 2024
@Trouffman Trouffman deleted the add-path-obs-ndi-detected branch December 22, 2024 04:19
@Trouffman
Copy link
Collaborator Author

This error-tweak can (should) be removed in future version after migration from pre distro-av to Distro-av is with very high adoption.

@Trouffman Trouffman restored the add-path-obs-ndi-detected branch December 22, 2024 04:21
@Trouffman Trouffman deleted the add-path-obs-ndi-detected branch December 22, 2024 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants