-
-
Notifications
You must be signed in to change notification settings - Fork 419
CI: Remove quotes '' from receipt and version strings #1032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
macOS pkg builds after version 4.11.1 included quotes around the identifier and version numbers, effecting the packages receipts. This causes issues for software deployment system like Munki that are now unable to correctly compare versions.
|
Very sorry for the delay on this! No excuses other than just being busy with other priorities... or lazy! :) I believe you that this is a problem. That said, it wouldn't be the first time I have first added a fix here and then opened a PR on https://github.com/obsproject/obs-plugintemplate to have them get around to it whenever they can. Is this a really big and/or urgent problem? |
|
No worries on the delay. It's really only an issue if you are using any type of deployment system to install the pkg and that system is using the receipts for installation checking/confirmation. I could open a PR on the parent project or defer to you doing it if you already have a rapport with them, what ever is smoother. It's a relatively minor change in the scheme of the project. Thanks so much. |
|
This should be suggested to the OBS-plugin-te plate for sure. Here are result of my research: So for the identifier I do not see the reason for it being used. For the version number this seems to be a similar story/behavior. "version number Each integer provides information about the release in the format [Major].[Minor].[Patch]. For example, in 10.14.1, 10 is the major revision number, 14 is the minor revision number, and 1 is the maintenance release number. This string is used throughout the system to identify the bundle version and should match the version number you enter in App Store Connect." So no need for quote as well it seems ^^ |
1 similar comment
|
This should be suggested to the OBS-plugin-te plate for sure. Here are result of my research: So for the identifier I do not see the reason for it being used. For the version number this seems to be a similar story/behavior. "version number Each integer provides information about the release in the format [Major].[Minor].[Patch]. For example, in 10.14.1, 10 is the major revision number, 14 is the minor revision number, and 1 is the maintenance release number. This string is used throughout the system to identify the bundle version and should match the version number you enter in App Store Connect." So no need for quote as well it seems ^^ |
|
@paulpv Note To Self to PR this to https://github.com/obsproject/obs-plugintemplate |
macOS pkg builds after version 4.11.1 included quotes around the identifier and version numbers, effecting the packages receipts. This causes issues for software deployment system like Munki that are now unable to correctly compare installed versions.