Audio only patch #1027
Closed
Audio only patch #1027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The audio-only was resetting the frame and settings parameter only when i was set. This created other issues that the "ndi receiver" reset was not done uniformly depending is there was video or audio only. This also created issue at launch to throw some error.
Member
|
How are we on this? Is this really the code/fix that we need, or were you still working or thinking on something else? |
Collaborator
Author
|
It works except for the identified limitation outlined in the OP. We should have this merged as it fixes quite a bunch of bugs, and the limitation is only for a new feature. We should release both, this fix and the new feature BUT highlights the known issue below :
Edit: Maybe we could add "beta" on the "Disconnect when not visible (beta)" feature. |
Merged
Collaborator
Author
|
This branch is out of date. And everything is now being fixed in #1043 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix a bug that exist since.... 2017 (IIRC)
BUT this is conflicting with some added new behavior when the source is enable but set to not keep the connection alive when not visible.
Fix audio bug that audio-Only mode does not work when restarting OBS.
Main bug with workaround solution: #592
Should fix the issues :
#429
#578
#981
#906
#621
#467
#298
This was tested and confirmed fixing the bug on MAC OS on OBS 30.1.1.