Is there an existing issue for this?

• I have searched the existing issues and did not find a similar issue

This bug exists on the latest available release of DistroAV and supported environment?

• I have checked this bug still exist on the latest available version of DistroAV
• I have checked that my OS / OBS / NDI versions are supported

OBS Log [URL] - Important!

No response

Issue reported - Current Behavior

OBS crash when enabling output after changing Outpu (Scaled) Resolution in Settings.

No entries that much in the logs.

[DistroAV] +main_output_init()
[DistroAV] +main_output_start()
[DistroAV] main_output_start: starting NDI main output 'OBS'
[DistroAV] +ndi_output_start(name='OBS', groups='', ...)

Crash logs shows:

obs.dll!obs_output_begin_data_capture+0x3ff
distroav.dll!ndi_output_start+0x234
obs.dll!obs_output_actual_start+0x6b
obs.dll!obs_output_start+0xcf
distroav.dll!main_output_init+0x490
distroav.dll!OutputSettings::onFormAccepted+0x135

Expected Behavior

Enable Output with the new resolution.

Steps To Reproduce

Reproduce on Windows (did not reproduce in MacOS)

1. Launch OBS
2. Settings > Video > Output (Scaled) Resolution > change this
3. Click OK
4. Open "DistroAV NDI Settings"
5. Enable Main Output
6. Click OK

This should crash.

I suspect this is because we do not use the proper resolution (don't read properly and still reference the older resolution memory)

Environment

- OS: Windows 11 24H2
- OBS: 31.0.1
- DistroAV: 6.0.0
- NDI: 6.1.1.0

Pre-Check for Bug Report

• I am able to reproduce the bug following the steps provided above
• I have confirmed this bug exist on more than one device/computer
• I have tested using a new scene collection to reproduce the issue
• I have tested on a 'clean' OBS installation (aka with no other scripts or plugin installed)