[Dev-Bug]: Opening the Plugin Settings Dialog stops NDI Output on PR 1148 #1180
Description
Is there an existing issue for this?
- I have searched the existing issues and did not find a similar issue
This bug exists on the latest available release of DistroAV and supported environment?
- I have checked this bug still exist on the latest available version of DistroAV
- I have checked that my OS / OBS / NDI versions are supported
OBS Log [URL] - Important!
No response
Happen on the Version in PR 1148 : #1148
Issue reported - Current Behavior
When NDI Output is enabled:
- Open the DistroAV NDI Settings
- This stops the NDI Output feed
- Press OK > NDI feed restart
- Press Cancel > NDI Feed does not restart
Expected Behavior
When NDI Output is enabled:
- Open the DistroAV NDI Settings
- NDI Output Feed is unchanged
- Only apply new settings when pressing OK
Steps To Reproduce
Launch OBS with DistroAV
- open DistroAV NDI settings
- Enable NDI Output & click OK
- Run a video loop / something to test with
- Open the feed on NDI monitor - confirm it works
- open DistroAV NDI settings
-> This will stop the NDI Output. (not supposed to) - Press Cancel > NDI Feed does not restart
Environment
This is on a Dev PR : https://github.com/DistroAV/DistroAV/pull/1148/commits/bbb010a305808bf618fe90ed9794318df8922c3a
- OS: MacOS
- OBS: 31.0.0
- DistroAV: https://github.com/DistroAV/DistroAV/pull/1148
- NDI: 6.1.0
Log file :
NDI Output Enabled > Open the DistroAV NDI Settings
`
01:23:07.715: DEPRECATION: obs_frontend_get_global_config is deprecated. Read from global or user configuration explicitly instead.
01:23:07.715: [DistroAV] +main_output_init()
01:23:07.715: DEPRECATION: obs_frontend_get_global_config is deprecated. Read from global or user configuration explicitly instead.
01:23:07.715: [DistroAV] +main_output_deinit()
01:23:07.715: [DistroAV] +main_output_stop()
01:23:07.715: [DistroAV] main_output_stop: stopping NDI main output 'OBS-PGM'
01:23:07.715: [DistroAV] +ndi_output_stop(name='OBS-PGM', groups='', ...)
01:23:07.715: Output 'NDI Main Output': stopping
01:23:07.715: Output 'NDI Main Output': Total frames output: 258
01:23:07.715: Output 'NDI Main Output': Total drawn frames: 259
01:23:07.715: [DistroAV] +on_main_output_stopped()
01:23:07.715: DEPRECATION: obs_frontend_get_global_config is deprecated. Read from global or user configuration explicitly instead.
01:23:07.715: [DistroAV] -on_main_output_stopped()
01:23:07.715: [DistroAV] -ndi_output_stop(name='OBS-PGM', groups='', ...)
01:23:07.715: [DistroAV] main_output_stop: successfully stopped NDI main output 'OBS-PGM'
01:23:07.715: [DistroAV] -main_output_stop()
01:23:07.715: [DistroAV] main_output_deinit: releasing NDI main output 'OBS-PGM'
01:23:07.721: [DistroAV] +ndi_output_destroy(name='OBS-PGM', groups='', ...)
01:23:07.721: [DistroAV] ndi_output_destroy: freeing 8192 bytes
01:23:07.721: [DistroAV] -ndi_output_destroy(name='OBS-PGM', groups='', ...)
01:23:07.721: [DistroAV] main_output_deinit: successfully released NDI main output ''
01:23:07.721: [DistroAV] -main_output_deinit()
01:23:07.721: [DistroAV] main_output_init: creating NDI main output 'OBS-PGM'
01:23:07.721: [DistroAV] +ndi_output_getdefaults()
01:23:07.721: [DistroAV] -ndi_output_getdefaults()
01:23:07.721: [DistroAV] +ndi_output_create(name='OBS-PGM', groups='', ...)
01:23:07.721: [DistroAV] ndi_output_update(name='OBS-PGM', groups='', ...)
01:23:07.721: [DistroAV] -ndi_output_create(name='OBS-PGM', groups='', ...)
01:23:07.721: [DistroAV] main_output_init: creating NDI main output 'OBS-PGM'
01:23:07.721: [DistroAV] +main_output_start()
01:23:07.721: [DistroAV] main_output_start: starting NDI main output 'OBS-PGM'
01:23:07.721: [DistroAV] +ndi_output_start(name='OBS-PGM', groups='', ...)
01:23:07.723: [DistroAV] +on_main_output_started()
01:23:07.723: DEPRECATION: obs_frontend_get_global_config is deprecated. Read from global or user configuration explicitly instead.
01:23:07.723: [DistroAV] -on_main_output_started()
01:23:07.723: [DistroAV] 'OBS-PGM' ndi_output_start: ndi output started
01:23:07.723: [DistroAV] -ndi_output_start(name='OBS-PGM', groups=''...)
01:23:07.723: [DistroAV] main_output_start: successfully started NDI main output 'OBS-PGM'
01:23:07.723: [DistroAV] -main_output_start()
01:23:07.723: [DistroAV] -main_output_init()
01:23:07.723: DEPRECATION: obs_frontend_get_global_config is deprecated. Read from global or user configuration explicitly instead.
01:23:07.723: [DistroAV] +main_output_deinit()
01:23:07.723: [DistroAV] +main_output_stop()
01:23:07.723: [DistroAV] main_output_stop: stopping NDI main output 'OBS-PGM'
01:23:07.723: [DistroAV] +ndi_output_stop(name='OBS-PGM', groups='', ...)
01:23:07.723: Output 'NDI Main Output': stopping
01:23:07.723: Output 'NDI Main Output': Total frames output: 0
01:23:07.723: Output 'NDI Main Output': Total drawn frames: 0
01:23:07.728: [DistroAV] +on_main_output_stopped()
01:23:07.728: DEPRECATION: obs_frontend_get_global_config is deprecated. Read from global or user configuration explicitly instead.
01:23:07.728: [DistroAV] -on_main_output_stopped()
01:23:07.728: [DistroAV] -ndi_output_stop(name='OBS-PGM', groups='', ...)
01:23:07.728: [DistroAV] main_output_stop: successfully stopped NDI main output 'OBS-PGM'
01:23:07.728: [DistroAV] -main_output_stop()
01:23:07.728: [DistroAV] main_output_deinit: releasing NDI main output 'OBS-PGM'
01:23:07.728: [DistroAV] +ndi_output_destroy(name='OBS-PGM', groups='', ...)
01:23:07.728: [DistroAV] -ndi_output_destroy(name='OBS-PGM', groups='', ...)
01:23:07.728: [DistroAV] main_output_deinit: successfully released NDI main output ''
01:23:07.728: [DistroAV] -main_output_deinit()
01:23:07.728: DEPRECATION: obs_frontend_get_global_config is deprecated. Read from global or user configuration explicitly instead.
01:23:07.728: DEPRECATION: obs_frontend_get_global_config is deprecated. Read from global or user configuration explicitly instead.
`Pre-Check for Bug Report
- I am able to reproduce the bug following the steps provided above
- I have confirmed this bug exist on more than one device/computer
- I have tested using a new scene collection to reproduce the issue
- I have tested on a 'clean' OBS installation (aka with no other scripts or plugin installed)