Closed
Conversation
Collaborator
IMO it shouldn't be the main testing strategy, it's definitely a painful to set up (you need to install external tools) so we can't expect every contributor to do it. I think the main tests should be done with unit tests and we can keep something like this in CI to catch edge-cases if feasible. |
Collaborator
Author
|
Closing in favor of #133. These generated tests are a disaster to maintain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
gentestscript which automatically generates tests comparing our results to Chrome's is broken and does not compilecargo run --package gentest#65.Context
This failure was discovered in #46.
Feedback wanted
sprawl::node::Stretch->sprawl::node::Sprawl#79.