Move cache logic to own module#432
Merged
nicoburns merged 7 commits intoDioxusLabs:mainfrom Apr 11, 2023
Merged
Conversation
e2c6d9b to
e8d4280
Compare
13 tasks
TimJentzsch
reviewed
Apr 10, 2023
Collaborator
TimJentzsch
left a comment
There was a problem hiding this comment.
I don't have objections about making the caching pub
TimJentzsch
approved these changes
Apr 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
This is mostly a code quality improvement. It moves the caching logic to it's own module, and makes it object-oriented. A bonus is that it allows us to make the new
Cachestruct public which enables users implementing theLayoutTreetrait manually to access our caching logic.Context
Split out from #326.
Builds on top of, and is blocked by #431
Feedback wanted
Cachestruct public?