Skip to content

Trampoline child measurement/layout through the LayoutTree trait#427

Merged
nicoburns merged 3 commits intoDioxusLabs:mainfrom
nicoburns:add-child-layout-function-to-layout-tree-trait
Apr 10, 2023
Merged

Trampoline child measurement/layout through the LayoutTree trait#427
nicoburns merged 3 commits intoDioxusLabs:mainfrom
nicoburns:add-child-layout-function-to-layout-tree-trait

Conversation

@nicoburns
Copy link
Copy Markdown
Collaborator

@nicoburns nicoburns commented Apr 10, 2023

Objective

The objective here it to make is easy to embed Taffy as part of a larger layout implementation rather than usage of Taffy requiring you to "buy in" to having all your layouting needs handled by Taffy.

This is the core change from #326
Fixes #28

Context

See #28 (comment)

Notes

Seems to be relatively perf-neutral.

@nicoburns nicoburns added enhancement New feature or request usability Make the library more comfortable to use breaking-change A change that breaks our public interface labels Apr 10, 2023
@nicoburns nicoburns mentioned this pull request Apr 10, 2023
Closed
13 tasks
@nicoburns nicoburns force-pushed the add-child-layout-function-to-layout-tree-trait branch from 4adf897 to e427cf7 Compare April 10, 2023 16:49
TimJentzsch
TimJentzsch reviewed Apr 10, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@TimJentzsch TimJentzsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems solid to me.

I think it would be great to add a simple example demonstrating how to use these new capabilities, if possible.
This would make it easier to detect limitations of the approach and also serve as a useful reference to library authors to integrate this.

@Weibye
Copy link
Copy Markdown
Collaborator

Weibye commented Apr 10, 2023

Seems solid to me.

I think it would be great to add a simple example demonstrating how to use these new capabilities, if possible. This would make it easier to detect limitations of the approach and also serve as a useful reference to library authors to integrate this.

Yes, it's strange that this doesn't affect any of our examples, which means our examples are lacking.

@nicoburns
Copy link
Copy Markdown
Collaborator Author

nicoburns commented Apr 10, 2023

Seems solid to me.
I think it would be great to add a simple example demonstrating how to use these new capabilities, if possible. This would make it easier to detect limitations of the approach and also serve as a useful reference to library authors to integrate this.

Yes, it's strange that this doesn't affect any of our examples, which means our examples are lacking.

This API was never really properly designed/launched. It was introduced as part of a PR which was necesary for refactoring Flexbox to interop with CSS Grid. One of my main aims for Taffy 0.4 is to sort this out and make this API useful.

@nicoburns nicoburns merged commit 325413c into DioxusLabs:main Apr 10, 2023
@nicoburns nicoburns deleted the add-child-layout-function-to-layout-tree-trait branch April 10, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile Awaiting requested review from alice-i-cecile

2 more reviewers

@TimJentzsch TimJentzsch TimJentzsch left review comments

@Weibye Weibye Weibye approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

breaking-change A change that breaks our public interface enhancement New feature or request usability Make the library more comfortable to use

Projects

None yet

Milestone

0.4

Development

Successfully merging this pull request may close these issues.

Support multiple layout algorithms

3 participants

@nicoburns @Weibye @TimJentzsch