Remove unused methods from the LayoutTree trait#425
Merged
nicoburns merged 3 commits intoDioxusLabs:mainfrom Apr 10, 2023
Merged
Remove unused methods from the LayoutTree trait#425nicoburns merged 3 commits intoDioxusLabs:mainfrom
nicoburns merged 3 commits intoDioxusLabs:mainfrom
Conversation
Removes: - parent (unused) - mark_dirty (make method on Taffy struct public) - is_childless (use child_count instead) - layout (use &Taffy instead of &LayoutTree for debug printing)
Weibye
suggested changes
Apr 10, 2023
Collaborator
Weibye
left a comment
There was a problem hiding this comment.
Nice! This should have an entry in the RELEASES.md?
Collaborator
Author
|
@Weibye Entry added to RELEASES.md (and formatting issues fixed) |
Weibye
approved these changes
Apr 10, 2023
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
The idea is to make the
LayoutTreetrait as minimal as possible to make it easy to implement.Removes:
Context
Split out from #326.
Feedback wanted
General PR review.