Merged
Conversation
Collaborator
|
Yep, unsurprised there's a subtle exponential blow-up. Very happy to have some benchmarks to track this: feel free to merge when you think it's ready. |
Collaborator
Author
|
3rd party benchmark https://oczpm.csb.app/ Analysis of browser grid layout perf https://blogs.igalia.com/jfernandez/2015/06/24/performance-on-grid-layout/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Provide a way to measure and track performance of the CSS Grid implementation.
Benchmark results
Unfortunately the actual performance is pretty atrocious.
Some notes:
We also seem to have a separate quadratic blowup with respect to the number of cells in a single level (this is after accounting for the fact that the grid is 2D)EDIT: Thewidebenchmarks turned out to not even be measuring the grid algorithm as I had forgotten to setdisplay🤦