Reinstate FlexStart and FlexEnd alignment variants#336
Merged
alice-i-cecile merged 2 commits intoDioxusLabs:mainfrom Jan 23, 2023
Merged
Conversation
06325ed to
b0690ce
Compare
alice-i-cecile
approved these changes
Jan 22, 2023
Collaborator
alice-i-cecile
left a comment
There was a problem hiding this comment.
Good docs, and a clean set of changes. I'm not thrilled that this exists, but that's the nature of the spec.
Weibye
approved these changes
Jan 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #307 (regression from Taffy 0.2). Taffy now has both
Start/EndandFlexStart/FlexEndas per the spec.We probably ought to duplicate all our alignment tests to test all 4 properties. But we do have at least some coverage of both sets of properties.