WIP: Fix Functional Tests #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gto90
approved these changes
Jun 15, 2022
Member
gto90
left a comment
There was a problem hiding this comment.
ACK
Great work on this @JaredTate . I will open two new issues to cover the functional test suite runner having trouble running all of the functional tests in a batch, and one for resolving the zmq functional test failure.
digicontributer
approved these changes
Jun 16, 2022
digicontributer
left a comment
There was a problem hiding this comment.
and one for resolving the zmq functional test failure.
ACK for this in that case.
Member
|
New issue raised for the functional test failures here: #95 |
Member
|
New issue raised for the failing zmq functional test here: #96 |
Member
|
cACK Great work @JaredTate. |
ycagel
approved these changes
Jun 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting draft PR for fixing & finalizing all functional tests. Right now we have 214 passing with 23 disabled ( not sure how many were also disabled in BTC for various reasons, or how many Yoshi commented out).
You can learn more about functional tests here: https://github.com/DigiByte-Core/digibyte/tree/feature/8.22.0/test
You can run all tests at once from the main digibyte directory after comping by running:
Note you can --jobs=N to add more threads. It defaults to 4, yet trying anywhere from 2 - 8 you get random test failures because the previous test node is not spun down correctly. Yet when you run the failing test individually it will pass.