Fix: Functional Tests #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be needed to postpone difficulty adjustment modifications to a block in the future throughout the functional tests
…sqlite warning message in DigiByte Core
…, CORE: increased peer timeouts
…ady being tracked' error
…get support for BIP68
… functional test)
…empool, even if they were not supposed to
…tocol consensus from 70016 to 70018
added 20 commits
April 6, 2022 14:00
… to bumped protocol version to 70018
…tial getaddr broadcast
…to DigiByte's small maturity param
…hain tx required due to small maturity of DigiByte coins
… that only one output is created
…-date with test_framework. 2/3 subtests are failing. Core code needs to be adjusted.
JaredTate
approved these changes
Apr 13, 2022
JaredTate
left a comment
There was a problem hiding this comment.
ACK. Once again amazing work @SmartArray. Having these tests working is a fundamental step towards a very stable 8.22. The client compiles, runs, and works great.
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Functional Tests
160 commits later, this PR finally fixes all 158 failing functional test by adapting them to the DigiByte network and chainparams.
Before this PR can be tested and merged, #89 needs to be accepted and merged because the functional tests will only run through if the core-related issues are fixed.
In order to fix the tests, it was required to
COIN_MATURITYparameterscryptas a python library that will be called during the tests-easypowthat turns off MultiAlgo during tests that are executed in regtest environment