Disable RBF transaction signalling #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmartArray
approved these changes
Jan 17, 2022
SmartArray
left a comment
There was a problem hiding this comment.
utACK.
This corresponds to TODO-002 from the list that I composed here: #63 (comment)
fgabelmannjr
approved these changes
Jan 23, 2022
JaredTate
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
ACK. Compiles, runs, sends, GUI shows it removed.
However during the process I noticed we have some theming issues. The icons in boxes to the right of Pay To box are not showing on send page like they should, but this issue was already there.
Before PR:
After PR:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To complement the Dandelion implementation; prevent signalling RBF on transactions generated from the UI. Other functions will remove unaffected (a soft-disable).