Skip to content

Conversation

@barrystyle
Copy link

This PR completes the Dandelion transaction implementation that was provided with v22.0

@JaredTate
Copy link

Awesome! Great to see this dandelion contribution. The code looks straighforward. So it builds, but looks like a segfault in tests:

osx:
addrman_tests from test/addrman_tests.cpp /bin/sh: line 1: 97492 Segmentation fault: 11 test/test_digibyte --catch_system_errors=no -l test_suite -t "cat test/addrman_tests.cpp | grep -E "(BOOST_FIXTURE_TEST_SUITE\\(|BOOST_AUTO_TEST_SUITE\\()" | cut -d '(' -f 2 | cut -d ',' -f 1 | cut -d ')' -f 1" -- DEBUG_LOG_OUT > test/addrman_tests.cpp.log 2>&1 Running 18 test cases... Entering test module "DigiByte Core Test Suite" test/arith_uint256_tests.cpp:20: Test suite "arith_uint256_tests" is skipped because disabled test/addrman_tests.cpp:132: Entering test suite "addrman_tests" test/addrman_tests.cpp:134: Entering test case "addrman_simple" make[3]: [test/addrman_tests.cpp.test] Error 1 make[2]: [check-am] Error 2 make[1]: * [check-recursive] Error 1

Linux:

../build-aux/test-driver: line 107: 24404 Segmentation fault (core dumped) "$@" > $log_file 2>&1 FAIL: qt/test/test_digibyte-qt

@JaredTate
Copy link

I am not able to reproduce segfault errors locally, I get it to build and make check fine. Will go ahead and merge it into the feature branch. Thanks again Barry!

@JaredTate JaredTate merged commit d351fd0 into DigiByte-Core:feature/8.22.0 Sep 14, 2021
@barrystyle barrystyle deleted the bugfix/dandelion-completed branch December 8, 2021 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants