Update Qt 5.9 source URL #50
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Windows binaries fail to build because of an invalid Qt 5.9 URL. As it turns out, https://download.qt.io/official_releases/qt/ doesn't provide that version anymore, the minimum official version is 5.12. However, Qt 5.9 can be found at the archive https://download.qt.io/archive/qt/5.9/
SmartArray
approved these changes
Jun 11, 2021
SmartArray
left a comment
There was a problem hiding this comment.
Looks very good to me. Thanks for your contribution!
utACK, as I have no Microsoft Windows to test it. However, having worked with Qt a lot in the past, I know that as long as the major version stays the same, everything should work as expected!
ChillingSilence
approved these changes
Jun 12, 2021
ChillingSilence
left a comment
There was a problem hiding this comment.
ACK, we're using 5.9.6, this fixes the URL, thank you @Jolly-Pirate
gto90
approved these changes
Jun 14, 2021
Member
gto90
left a comment
There was a problem hiding this comment.
ACK. Thanks kindly for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows binaries fail to build because of an invalid Qt 5.9 URL. As it turns out, https://download.qt.io/official_releases/qt/ doesn't provide that version anymore, the minimum official version is 5.12. However, Qt 5.9 can be found at the archive https://download.qt.io/archive/qt/5.9/