tests: Fix Taproot activation and wallet_taproot.py functional test #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the feature_taproot.py functional test by correctly setting DUST_LIMIT and MIN_FEE to match 8.22 fee changes and COINBASE_MATURITY_2.
This commit fixes the feature_taproot.py functional test by correctly setting DUST_LIMIT and MIN_FEE to match 8.22 fee changes and COINBASE_MATURITY_2.
…Byte-Core/digibyte into bugfix/test-feature_taproot
ycagel
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the Taproot soft fork tests and the blockchain info RPC. The changes involve updating constants, adjusting test parameters, and modifying the blockchain info output.
Updates to Taproot softfork tests:
test/functional/feature_taproot.py: UpdatedCOINBASE_MATURITYtoCOINBASE_MATURITY_2to reflect the new maturity period. [1] [2]test/functional/feature_taproot.py: AdjustedDUST_LIMITandMIN_FEEvalues to new limits.Modifications to blockchain info RPC:
test/functional/rpc_blockchain.py: Changed the Taproot status to 'active', updated the start time and timeout values, and added theheightfield in the blockchain info output.Motivation
These changes ensure compatibility and accuracy for the updated Taproot soft fork parameters and protocol behaviors. Specifically, the modifications address issues in the wallet_taproot.py functional test, which validates the generation and spending of Pay-to-Taproot (P2TR) addresses.
Testing
Additional Notes
No changes to the documentation or other test suites are required as part of this update.