Skip to content

DigiByte Core ( BTC22.1 Backports for BTC Core 22 ) #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ycagel merged 13 commits into from Apr 13, 2024
Merged

DigiByte Core ( BTC22.1 Backports for BTC Core 22 ) #232

ycagel merged 13 commits into from Apr 13, 2024

Conversation

@ghost
Copy link

@ghost ghost commented Apr 10, 2024 •
edited by ghost
Loading

@ghost ghost changed the title DigiByte Core ( BTC22.1 Backports for BTC22 ) DigiByte Core ( BTC22.1 Backports for BTC Core 22 ) Apr 10, 2024
@JaredTate
Copy link

JaredTate commented Apr 13, 2024 •
edited
Loading

So this PR compiles, runs, and all tests pass. But when looking at all was exactly changed you reference:
build: patch qt to explicitly define previously implicit header include #23580

But those changes are not in this PR? Were they already changed?

Screenshot 2024-04-13 at 7 52 36 AM

@ghost
Copy link
Author

ghost commented Apr 13, 2024 •
edited by JaredTate
Loading

So this PR compiles, runs, and all tests pass. But when looking at all was exactly changed you reference: build: patch qt to explicitly define previously implicit header include #23580

But those changes are not in this PR? Were they already changed?

Screenshot 2024-04-13 at 7 52 36 AM

Yes parts where already in it. After this pr we have all updates/fix from btc core 22.1. In DigiByte core.

@JaredTate
Copy link

JaredTate commented Apr 13, 2024

Yes parts where already in it. After this pr we have all updates/fix from btc core 22.1. In DigiByte core.

Awesome, good stuff. The rest look straightforward and helpful. I am waiting for all the Python functional tests to run and will ACK it.

gto90
gto90 approved these changes Apr 13, 2024
View reviewed changes
Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

JaredTate
JaredTate approved these changes Apr 13, 2024
View reviewed changes
Copy link

@JaredTate JaredTate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK! Good work @Jongjan88 All python functional tests pass too.
Screenshot 2024-04-13 at 9 36 17 AM

ycagel
ycagel approved these changes Apr 13, 2024
View reviewed changes
Copy link
Member

@ycagel ycagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK.

@ycagel ycagel merged commit eb94077 into DigiByte-Core:develop Apr 13, 2024
@ghost ghost deleted the btc221 branch April 13, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SmartArray SmartArray Awaiting requested review from SmartArray

@digicontributer digicontributer Awaiting requested review from digicontributer

@j50ng j50ng Awaiting requested review from j50ng

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JaredTate @ycagel @gto90