Skip to content

Conversation

@JaredTate
Copy link

This PR fixes 6 remaining functional tests that had recently been broken with changes. Fixes in: wallet_create_tx.py, wallet_importdescriptors.py, wallet_bumpfee.py, wallet_basic.py.

wallet_bumpfee.py: As replace by fee was disabled in DGB GUI, part of bumpfee was disabled on core protocol but most of the bump fee code is still active in core protocol, it just cannot be accessed in GUI. With that I could not get one section of bumpfee tests to work because of disabled code.

Wallet_basic.py: At very end of test a legacy-wallet bypass was added for the abandon transaction test for legacy-wallet. Descriptors wallet working as expected. For whatever reason it already gets added to mempool and no tx to abandon for rawmempool. This needs to be sorted with dandelion and mempool behavior. Next step would be getting the dandelion python test working for the first time ever. This may be a side effect of having dandelion as well, I am not sure. We need to test dandelion with descriptor wallets as well.

To test this:

Compile:

  ./autogen.sh
  ./configure
  make -j 8

Run Specific Functional Tests

test/functional/test_runner.py wallet_create_tx.py wallet_importdescriptors.py wallet_bumpfee.py wallet_basic.py

Screenshot 2024-03-25 at 10 42 59 AM

Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ghost
Copy link

ghost commented Mar 25, 2024

Nice work @JaredTate !!
Screenshot from 2024-03-25 18-21-37

Copy link
Member

@ycagel ycagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK. Great work @JaredTate!

@ycagel ycagel merged commit 7382609 into DigiByte-Core:develop Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants