Skip to content

Fix 4 Functional Tests #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ycagel merged 2 commits into from
Mar 21, 2024
Merged

Fix 4 Functional Tests #212

ycagel merged 2 commits into from
Mar 21, 2024
+14 −10

Conversation

@JaredTate
Copy link

@JaredTate JaredTate commented Mar 21, 2024 •
edited
Loading

This PR fixes 4 functional tests between rpc_rawtransaction.py and wallet_keypool.py.

To test this:

Compile:

  ./autogen.sh
  ./configure
  make -j 8

Run Specific Functional Tests

test/functional/test_runner.py rpc_rawtransaction.py wallet_keypool.py

Screenshot 2024-03-21 at 1 13 27 PM

Screenshot 2024-03-21 at 1 28 12 PM

@ycagel ycagel requested review from a user, SmartArray, digicontributer, gto90, j50ng and ycagel March 21, 2024 19:17
@JaredTate JaredTate changed the title Fix 2 rpc_rawtransaction.py Functional Tests Fix 4 Functional Tests Mar 21, 2024
gto90
gto90 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@gto90 gto90 added the bug Something isn't working label Mar 21, 2024
ghost
ghost approved these changes Mar 21, 2024
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! @JaredTate
Screenshot from 2024-03-21 20-54-56

ACK Tested

ycagel
ycagel approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@ycagel ycagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK

@ycagel ycagel merged commit d0522f8 into DigiByte-Core:develop Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ycagel ycagel ycagel approved these changes

@gto90 gto90 gto90 approved these changes

@SmartArray SmartArray Awaiting requested review from SmartArray

@digicontributer digicontributer Awaiting requested review from digicontributer

@j50ng j50ng Awaiting requested review from j50ng

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

@JaredTate JaredTate

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JaredTate @ycagel @gto90