Skip to content

Fix wallet_abandonconflict.py Functional Tests #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gto90 merged 1 commit into from
Mar 20, 2024
Merged

Fix wallet_abandonconflict.py Functional Tests #209

gto90 merged 1 commit into from
Mar 20, 2024

Conversation

@JaredTate
Copy link

@JaredTate JaredTate commented Mar 20, 2024

This PR fixes wallet_abandonconflict.py functional tests.

To test this:

Compile:

  ./autogen.sh
  ./configure
  make -j 8

Run Specific Functional Tests

test/functional/test_runner.py wallet_abandonconflict.py

Screenshot 2024-03-19 at 3 31 15 PM

@ycagel ycagel requested review from a user, SmartArray, digicontributer, gto90, j50ng and ycagel March 20, 2024 02:55
@ghost
Copy link

ghost commented Mar 20, 2024 •
edited by ghost
Loading

Test already work?
Screenshot from 2024-03-20 09-31-01
Screenshot from 2024-03-20 09-34-56

Test fixed in PR #190

@JaredTate
Copy link
Author

JaredTate commented Mar 20, 2024

This is very strange, the test was failing for me over and over yesterday for several hours until I made those changes. Let me clean and revert and see if it passes.

@ghost
Copy link

ghost commented Mar 20, 2024 •
edited by ghost
Loading

This is very strange, the test was failing for me over and over yesterday for several hours until I made those changes. Let me clean and revert and see if it passes.

Yes sometimes if i do the test to fast. Some also fail for me.

@JaredTate
Copy link
Author

JaredTate commented Mar 20, 2024

This is very strange, the test was failing for me over and over yesterday for several hours until I made those changes. Let me clean and revert and see if it passes.

Yes sometimes if I do the test too fast. Some also fail for me.

I only run 1 job at a time. But I ran this individually... it failed numerous times till I made this PR. I don't understand what other change we made recently. Currently, with this PR, these are my remaining failures:

Screenshot 2024-03-19 at 8 14 14 PM

@ghost
Copy link

ghost commented Mar 20, 2024 •
edited by ghost
Loading

This is very strange, the test was failing for me over and over yesterday for several hours until I made those changes. Let me clean and revert and see if it passes.

Yes sometimes if I do the test too fast. Some also fail for me.

I only run 1 job at a time. But I ran this individually... it failed numerous times till I made this PR. I don't understand what other change we made recently. Currently, with this PR, these are my remaining failures:

Screenshot 2024-03-19 at 8 14 14 PM

ACK Tested. Old and new test are working for me. @JaredTate

ycagel
ycagel approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@ycagel ycagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK

gto90
gto90 approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@gto90 gto90 merged commit 183cbfe into DigiByte-Core:develop Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ycagel ycagel ycagel approved these changes

@gto90 gto90 gto90 approved these changes

@SmartArray SmartArray Awaiting requested review from SmartArray

@digicontributer digicontributer Awaiting requested review from digicontributer

@j50ng j50ng Awaiting requested review from j50ng

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JaredTate @ycagel @gto90