Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Mar 17, 2024

Fix for Boost 1_84_0

Screenshot from 2024-03-17 23-17-03
Screenshot from 2024-03-17 23-43-13


With this PR

Screenshot from 2024-03-17 23-34-16

Jan added 3 commits March 17, 2024 23:48
copy_option to copy_options
overwrite_if_exists to overwrite_existing
@ghost ghost changed the title Fix core for Boost 1_84_0 Fix for Boost 1_84_0 Mar 17, 2024
Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Good find @Jongjan88 !

Copy link
Member

@ycagel ycagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK. Great job @Jongjan88!

Copy link

@JaredTate JaredTate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Good stuff. Compiles, runs good and make check has no failures.

Screenshot 2024-03-18 at 8 34 40 AM

@JaredTate JaredTate merged commit 17fcaf9 into DigiByte-Core:develop Mar 18, 2024
@ghost ghost deleted the pr2 branch March 18, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants