Skip to content

Fix rpc_blockchain.py Functional Test #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ycagel merged 2 commits into from
Mar 15, 2024
Merged

Fix rpc_blockchain.py Functional Test #203

ycagel merged 2 commits into from
Mar 15, 2024

Conversation

@JaredTate
Copy link

@JaredTate JaredTate commented Mar 15, 2024 •
edited
Loading

This PR fixes the rpc_blockchain.py functional test. The taproot deployment info was previously disabled within getblockchaininfo RPC command. So these changes disable it here for the time being.

To test this:

Compile:

  ./autogen.sh
  ./configure
  make -j 8

Run Specific Functional Tests

test/functional/test_runner.py rpc_blockchain.py

Screenshot 2024-03-15 at 3 44 52 PM

@JaredTate JaredTate changed the title Fix feature_taproot.py Functional Test Fix rpc_blockchain.py Functional Test Mar 15, 2024
@ycagel ycagel requested review from a user, SmartArray, digicontributer, gto90, j50ng and ycagel March 15, 2024 21:49
gto90
gto90 approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@ghost
Copy link

ghost commented Mar 15, 2024

Screenshot from 2024-03-15 23-02-04

ACK Tested!! Nice work. @JaredTate

ycagel
ycagel approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@ycagel ycagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK.

@ycagel ycagel merged commit 7d39358 into DigiByte-Core:develop Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ycagel ycagel ycagel approved these changes

@gto90 gto90 gto90 approved these changes

@SmartArray SmartArray Awaiting requested review from SmartArray

@digicontributer digicontributer Awaiting requested review from digicontributer

@j50ng j50ng Awaiting requested review from j50ng

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JaredTate @ycagel @gto90