Skip to content

Update amount_tests.cpp #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gto90 merged 1 commit into from
Mar 15, 2024
Merged

Update amount_tests.cpp #201

gto90 merged 1 commit into from
Mar 15, 2024

Conversation

@JaredTate
Copy link

@JaredTate JaredTate commented Mar 15, 2024 •
edited
Loading

This PR fixes amount_tests.cpp unit test on Linux. This test passes on mac but not linux because it appears the compilers handle it differently. Seems to be an int32 vs 64 issue. The test worked great for BTC, but not DGB with a larger MAX_MONEY integer.

make check should now pass on all platforms.

You can read more about Unit Tests here:
https://github.com/DigiByte-Core/digibyte/blob/develop/src/test/README.md

To Compile & Run Unit Tests:

  ./autogen.sh
  ./configure
  make -j 8
  make check

Run Specific Unit Test Fixed

cd src/test
./test_digibyte --run_test=amount_tests

Thanks to @Jongjan88 for pointing this out & testing the fix!

@ycagel ycagel requested review from a user, SmartArray, digicontributer, gto90, j50ng and ycagel March 15, 2024 17:20
ghost
ghost approved these changes Mar 15, 2024
View reviewed changes
Copy link

@ghost ghost left a comment •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK Nice work. @JaredTate

@JaredTate
Copy link
Author

JaredTate commented Mar 15, 2024

ACK Nice work. @JaredTate

Thank you for identifying this issue, working on a fix & testing it on Linux!

ycagel
ycagel approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@ycagel ycagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK

gto90
gto90 approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK

@gto90 gto90 merged commit 50748be into DigiByte-Core:develop Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ycagel ycagel ycagel approved these changes

@gto90 gto90 gto90 approved these changes

@SmartArray SmartArray Awaiting requested review from SmartArray

@digicontributer digicontributer Awaiting requested review from digicontributer

@j50ng j50ng Awaiting requested review from j50ng

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JaredTate @ycagel @gto90