Skip to content

Partial wallet_basic.py Fix & 5 other Functional Test Fixes #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gto90 merged 5 commits into from
Mar 10, 2024
Merged

Partial wallet_basic.py Fix & 5 other Functional Test Fixes #189

gto90 merged 5 commits into from
Mar 10, 2024

Conversation

@JaredTate
Copy link

@JaredTate JaredTate commented Mar 8, 2024 •
edited
Loading

This PR fixes 1 of 2 functional tests for wallet_basic.py and 5 other functional tests. This test wallet_basic.py is a doozy and after spending a few hours on it I figured I would share what I have done so far to see if anyone else has suggestions.

To test this:

Compile:

  ./autogen.sh
  ./configure
  make -j 8

Run Specific Functional Tests

test/functional/test_runner.py wallet_basic.py
test/functional/test_runner.py interface_digibyte_cli.py mining_basic.py mempool_unbroadcast.py rpc_signrawtransaction.py wallet_importprunedfunds.py

Screenshot 2024-03-08 at 9 37 22 AM

Screenshot 2024-03-08 at 10 07 21 AM

Screenshot 2024-03-08 at 11 32 13 AM

Screenshot 2024-03-08 at 8 52 16 AM

I am still stuck on this error for 2nd wallet_basic.py test:

Screenshot 2024-03-08 at 8 52 09 AM

@ycagel ycagel requested review from a user, SmartArray, digicontributer, gto90, j50ng and ycagel March 8, 2024 15:57
@JaredTate JaredTate changed the title Partial wallet_basic.py Fix 1 of 2 Tests Partial wallet_basic.py Fix & 4 Functional Test Fixes Mar 8, 2024
@JaredTate JaredTate changed the title Partial wallet_basic.py Fix & 4 Functional Test Fixes Partial wallet_basic.py Fix & 5 Functional Test Fixes Mar 8, 2024
@JaredTate JaredTate changed the title Partial wallet_basic.py Fix & 5 Functional Test Fixes Partial wallet_basic.py Fix & 5 other Functional Test Fixes Mar 8, 2024
@JaredTate
Copy link
Author

JaredTate commented Mar 8, 2024

After this PR I still have 39 failing tests.
Screenshot 2024-03-08 at 11 33 08 AM

ghost
ghost approved these changes Mar 8, 2024
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! @JaredTate
Screenshot from 2024-03-08 19-51-21
Same here 39 test Failed.
ACK Tested

ycagel
ycagel approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@ycagel ycagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK. Excellent work @Jongjan88 and @JaredTate!

gto90
gto90 approved these changes Mar 10, 2024
View reviewed changes
Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@gto90 gto90 merged commit c256f9b into DigiByte-Core:develop Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ycagel ycagel ycagel approved these changes

@gto90 gto90 gto90 approved these changes

@SmartArray SmartArray Awaiting requested review from SmartArray

@digicontributer digicontributer Awaiting requested review from digicontributer

@j50ng j50ng Awaiting requested review from j50ng

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JaredTate @ycagel @gto90