Skip to content

This PR fixes 5 functional tests. #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gto90 merged 3 commits into from Mar 8, 2024
Merged

This PR fixes 5 functional tests. #187

gto90 merged 3 commits into from Mar 8, 2024

Conversation

@ghost
Copy link

@ghost ghost commented Mar 8, 2024

This PR fixes 5 functional tests.

To test this:

Compile:

./autogen.sh
./configure
make -j 8

Run Specific Functional Tests

python wallet_send.py --descriptors 
python wallet_send.py --legacy-wallet
python rpc_net.py
python wallet_balance.py --descriptors
python wallet_balance.py --legacy-wallet

@JaredTate
Copy link

JaredTate commented Mar 8, 2024

Awesome! Wallet compiles & runs well, but 1 of the 5 tests still fails for me. wallet_balance.py --legacy-wallet failed,

Screenshot 2024-03-07 at 6 38 49 PM

@JaredTate
Copy link

JaredTate commented Mar 8, 2024 •
edited
Loading

Never mind, rerunning wallet_balance.py --legacy-wallet again and it works. I've noticed a lot of tests intermittently fail and need to be re-run.

Screenshot 2024-03-07 at 6 41 56 PM

JaredTate
JaredTate approved these changes Mar 8, 2024
View reviewed changes
Copy link

@JaredTate JaredTate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. Great work! Straight forward changes.

@JaredTate
Copy link

JaredTate commented Mar 8, 2024

FYI you can run multiple tests by daisy chaining them for a custom test:

Example:
test/functional/test_runner.py wallet_send.py rpc_net.py wallet_balance.py

@beggsdl
Copy link

beggsdl commented Mar 8, 2024

Great job guys. It is great to see so many of the tests being addressed.

ycagel
ycagel approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@ycagel ycagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cACK. Good work @Jongjan88!

gto90
gto90 approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@gto90 gto90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@gto90 gto90 merged commit 6723284 into DigiByte-Core:develop Mar 8, 2024
@ghost ghost deleted the newpr branch March 8, 2024 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@j50ng j50ng Awaiting requested review from j50ng

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JaredTate @beggsdl @ycagel @gto90