Fix 1st 5 Functional Tests #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Mar 5, 2024
ghost
left a comment
There was a problem hiding this comment.
@JaredTate Thank you for the pr. Nice work.
ghost
approved these changes
Mar 5, 2024
Author
|
lol |
sorry!! I did gh pr close. |
Author
It's all good! Thanks for your help! :) |
ycagel
approved these changes
Mar 5, 2024
Member
ycagel
left a comment
There was a problem hiding this comment.
cACK. Thanks for the efforts @JaredTate!
|
Nice work @JaredTate. I was glad to see you got rid of COINBASE_MATURITY_ORIGINAL and used COINBASE_MATURITY_2 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the first 5 functional tests. I am splitting this up so it does not get super unwieldy to review for fixing all the tests. Many changes are changing
COINBASE_MATURITY_ORIGINALtoCOINBASE_MATURITY_2to match core protocol terminology.To test this do:
Compile:
Run Functional Tests
Should pass first 5 & fail on 6th test: