Disable taproot until we find a solution to prevent chain bloats #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58e371b to
f2da74a
Compare
JaredTate
approved these changes
Apr 1, 2023
JaredTate
left a comment
There was a problem hiding this comment.
tACK. I also just added the same delay for Regtest and Testnet taproot activation code. I agree this first R/C should be delayed till we have more time for a proper solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR effectively disables taproot by setting it's activation date to year 2099.
We effectively disabled the activation by postponing it (instead of removing all taproot related code) so that we can easily reintroduce it in a future release when we have a fix ready to prevent the blockchain bloat that is happening on other chains right now. Additionally, this has the positive side effect that the functional tests regarding the activation of taproot will remain working.
Author's note
I am all for NFTs but it makes much more sense to store secure cryptographic hashes of your data instead of the raw data itself.