Fixed remaining Functional tests for 8.22 #106
Conversation
…multiple boost versions
…s.py: -easypow parameter added for regtest transactions
… as tested in init_tests.cpp by walletinit_verify_walletdir_no_trailing2 and walletinit_verify_walletdir_no_trailing
|
Yoshi, you legend! 👏 |
|
Cherry picked commits No modifications in your OpenSSL installation needed with these fixes. |
Bitcoin Core completely ripped out SSL tests as OpenSSL3 changed a ton of stuff and broke many things in core tests.
|
Bitcoin Core completely ripped out OpenSSL tests as OpenSSL3 changed a ton of stuff and broke many things in core tests. Just pushed a change to get tests passing and disable the broken SSL tests. To date OpenSSL tests are not back in BTC core v22 or 23. Added the following to configure.ac
Look here for BTC devs rationale for removing OpenSSL tests: bitcoin-core/secp256k1#983 |
gto90
left a comment
There was a problem hiding this comment.
ACK
Thank you for this hard work @SmartArray !
I have tested this on MacOS 13.2 with an M1 CPU as well as Ubuntu Linux 22.10. All unit tests pass as well as all functional tests.
JaredTate
left a comment
There was a problem hiding this comment.
ACK. Thank you Yoshi and everyone for your work on this!
This PR fixes the remaining functional tests.
It fixes the invalid mempool notification behaviour caused by Dandelion, which was basically announcing TXs twice.
Also fixed a few minor by adapting them to the new boost-API or disabling IPv6 tests (that will be working in 8.23)