Inconsistent formatting of filename and folder names between DigiByte Core releases #138
Description
[UPDATE: I have rewritten this explanation, after digging deeper into the issue.]
I am in the process of updating DigiNode Tools so that you can optionally switch between the DigiByte Core release version and the pre-release version (if available). This will make it easy for DigiNode users to quickly install/upgrade to the pre-release version with minimal effort, and even revert back to the release version in the event of a problem.
I have the changes to my script pretty much finished, except that I have noticed an inconsistency with the formatting of the release filename for 8.22.0-rc2, which is breaking my script.
Currently in my script the download URL is formatted like this: https://github.com/DigiByte-Core/digibyte/releases/download/v${DGB_VER_RELEASE}/digibyte-${DGB_VER_RELEASE}-${ARCH}-linux-gnu.tar.gz
It inserts the relevant variables as needed:
DGB_VER_RELEASE=digibyte_core_release_version_number e.g. 7.17.3 or 8.22.0-rc1
ARCH=system_architecture e.g. aarch64
This works fine for 7.17.2, 7.17.3 and 8.22.0-rc1:
https://github.com/DigiByte-Core/digibyte/releases/download/v7.17.2/digibyte-7.17.2-aarch64-linux-gnu.tar.gz
https://github.com/DigiByte-Core/digibyte/releases/download/v7.17.3/digibyte-7.17.3-aarch64-linux-gnu.tar.gz
https://github.com/DigiByte-Core/digibyte/releases/download/v8.22.0-rc1/digibyte-8.22-rc1-aarch64-linux-gnu.tar.gz
Unfortunately it breaks on 8.22.0-rc2:
With 8.22.0-rc2, the filename now has a letter 'v' before the version number (not to mention the capitalisation in 'DigiByte'). This means my script is not able to correctly generate the correct URL and the download fails.
Obviously, for DigiNode Tools to be able to automatically download all future releases of DigiByte Core automatically, it helps if the formatting of the filename is consistent across all releases. If this is a one off mistake, that's fine - I can obviously handle the discrepancy on this occasion by tweaking the download URL for 8.22.0-rc2 but if not, I think it is really important to ensure there is consistency. It affects anyone who is trying to download DigiByte automatically using bash scripts etc.