feature/gmodels: Allow generic In/Out on models#248
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #248 +/- ##
==========================================
- Coverage 66.01% 65.26% -0.75%
==========================================
Files 5 29 +24
Lines 2401 6664 +4263
Branches 641 1573 +932
==========================================
+ Hits 1585 4349 +2764
- Misses 520 1472 +952
- Partials 296 843 +547
|
|
@gbaydin I think this can be merged, or you can take the change and apply it into your own work on transformers? It raises separate questions of generalizing differentiable objects to beyond tensors but I think we can deal with those later, this seems like a reasonable minimal start? |
|
Actually this is indeed very relevant for the type of things I'm working on. For example in recurrent models I had to think about a design to pass and return hidden state tensors in addition to the input and return values of |
|
@dsyme I added a couple of fixes. I think the most important one was that I also moved a few things that were not involving I'm really happy about this PR in general. I think this is quite nice and powerful! For example, we can do things like:
Also after reading through all |
|
This is great, thanks for refining it! |
Generalises models to allow a generic In/Out, as used in transformer architectures
There are other ways to do this but this seems as good as any.