fix: Add fake signal to prevent blueapi hanging on shutdown #1277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to an assumed bug in libca, processes that import ophyd but do not create any signals do not exit cleanly. As the main process in blueapi never creates any signals (they are all created and managed by the task worker threads), the process always hangs at exit. Creating a non-functional signal if ophyd has been imported means the process can exit cleanly again. This also solves the problem where the environment cannot be reset if no devices are defined (for the same reason).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1277 +/- ##
=======================================
Coverage 94.75% 94.76%
=======================================
Files 41 41
Lines 2670 2674 +4
=======================================
+ Hits 2530 2534 +4
Misses 140 140 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DiamondJoseph
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is awful in so many ways but having to kill the process via SIGKILL every time it runs is a pain, especially for things like pytest which would otherwise complete without any interaction.