Skip to content

test(dgw): add AI Gateway smoke tests #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CBenoit merged 1 commit into from
Nov 27, 2025
Merged

test(dgw): add AI Gateway smoke tests #1590

CBenoit merged 1 commit into from
Nov 27, 2025

Conversation

Copy link
Contributor

Copilot AI commented Nov 27, 2025 •
edited
Loading

  • Understand AI Gateway implementation and test patterns
  • Add AI Gateway configuration support to testsuite/src/dgw_config.rs
  • Create ai_gateway.rs test file in testsuite/tests/cli/dgw/
  • Implement mock AI provider server
  • Implement smoke tests for AI Gateway endpoints
  • Test gateway API key authentication
  • Run tests to validate implementation
  • Address code review feedback:
    • Added setter(into) to ai_gateway field for consistency with other Option fields
    • Improved error handling consistency: use unwrap_or(0) instead of unwrap() in both mock server functions

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI mentioned this pull request Nov 27, 2025
Merged
Base automatically changed from experimental-ai-gateway to master November 27, 2025 11:24
CBenoit
CBenoit reviewed Nov 27, 2025
View reviewed changes
@CBenoit
Copy link
Member

CBenoit commented Nov 27, 2025

@copilot Perform a self-review, comparing the new code with the existing one and ensure consistency.

Copilot AI changed the title [WIP] Add multi-provider AI Gateway feature test(dgw): add AI Gateway smoke tests Nov 27, 2025
Copilot AI requested a review from CBenoit November 27, 2025 11:45
CBenoit
CBenoit reviewed Nov 27, 2025
View reviewed changes
Copy link
Contributor Author

Copilot AI commented Nov 27, 2025

@copilot Perform a self-review, comparing the new code with the existing one and ensure consistency.

Performed self-review and found an inconsistency: spawn_mock_status_server used .unwrap() on read_line while spawn_mock_openai_server used .unwrap_or(0). Fixed in commit 453bb8e to use .unwrap_or(0) consistently across both mock server functions.

Copilot AI requested a review from CBenoit November 27, 2025 11:54
@CBenoit
test(dgw): add AI Gateway smoke tests in testsuite crate
fae0a95 
Co-authored-by: CBenoit <3809077+CBenoit@users.noreply.github.com>
@CBenoit CBenoit force-pushed the copilot/sub-pr-1588-again branch from 19e4c82 to fae0a95 Compare November 27, 2025 12:05
@CBenoit CBenoit marked this pull request as ready for review November 27, 2025 12:05
@CBenoit CBenoit enabled auto-merge (squash) November 27, 2025 12:06
@CBenoit CBenoit merged commit 54e57d0 into master Nov 27, 2025
40 checks passed
@CBenoit CBenoit deleted the copilot/sub-pr-1588-again branch November 27, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mamoreau-devolutions mamoreau-devolutions mamoreau-devolutions approved these changes

@CBenoit CBenoit Awaiting requested review from CBenoit

Assignees

@CBenoit CBenoit

Copilot code review Copilot

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CBenoit @mamoreau-devolutions