fix(jetsocat): make the MCP proxy non intrusive #1514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b0096fb to
d3ddc1f
Compare
033e420 to
3e5a528
Compare
6e01dc8 to
185d843
Compare
The MCP proxy was previously handling the initialize request itself and returning a response instead of forwarding it to the target MCP server. It also intercepted notifications/initialized and logging/ setLevel without passing them through. Additionally, any unknown methods were being answered with an error response, even though the actual server might support them. This change forwards all requests and notifications directly to the server to ensure correct behavior and compatibility.
pacmancoder
reviewed
Oct 1, 2025
| if let Some(text) = item_obj.get_mut("text") { | ||
| if let Some(s) = text.get::<String>() { | ||
| let decoded = s | ||
| .replace("\\u0027", "'") |
Contributor
There was a problem hiding this comment.
That may be the biggest if chain I've ever seen 😄
Member
Author
There was a problem hiding this comment.
Yeah right! 😂
This was a remaining of the AI-generated stuff from Marc-André’s repo: https://github.com/awakecoding/mcp-proxy-tool/blob/5c8e1664c06c2e0fea2c5f5e861788bd188adfe6/src/main.rs#L285-L306
But got worse when I removed serde-json
pacmancoder
reviewed
Oct 1, 2025
| [dependencies] | ||
| anyhow = "1.0" | ||
| assert_cmd = "2.0" | ||
| dynosaur = "0.3" |
Contributor
There was a problem hiding this comment.
Wow, didn't know about that cool crate!
Member
Author
There was a problem hiding this comment.
It’s actually recommended over async-trait now! The implementer does not need to know about the crate too 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MCP proxy was previously handling the initialize request itself and returning a response instead of forwarding it to the target MCP server. It also intercepted notifications/initialized and logging/ setLevel without passing them through.
Additionally, any unknown methods were being answered with an error response, even though the actual server might support them.
This change forwards all requests and notifications directly to the server to ensure correct behavior and compatibility.
Issue: DGW-308