Skip to content

fix(player): add autoplay attribute to WebM video player #1487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CBenoit merged 1 commit into from
Sep 8, 2025
Merged

fix(player): add autoplay attribute to WebM video player #1487

CBenoit merged 1 commit into from
Sep 8, 2025

Conversation

@irvingoujAtDevolution
Copy link
Contributor

@irvingoujAtDevolution irvingoujAtDevolution commented Sep 8, 2025

Summary

  • Adds missing autoplay attribute to the WebM video player component
  • Fixes issue where recordings were not auto-starting when embedded in iframes

Test plan

  • Verify that WebM recordings auto-start when loaded in iframe
  • Test that existing controls (play/pause, muted) still work correctly
  • Build passes successfully

DGW-296

@irvingoujAtDevolution
fix(player): add autoplay attribute to WebM video player
62154c4 
Fixes issue where recordings were not auto-starting when embedded in iframes.
The multi-video-player component now includes the autoplay attribute alongside
the existing controls and muted attributes.

DGW-296
@github-actions
Copy link

github-actions bot commented Sep 8, 2025

Let maintainers know that an action is required on their side

  • Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

  • Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

  • Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

  • Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

Copilot AI reviewed Sep 8, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds the missing autoplay attribute to the WebM video player component to enable automatic playback when recordings are embedded in iframes.

  • Adds autoplay attribute to the video element in the WebM player
  • Fixes issue where WebM recordings were not auto-starting in iframe contexts

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

webapp/player-project/src/players/webm.ts
videoPlayer.setAttribute('height', '100%');
videoPlayer.setAttribute('controls', '');
videoPlayer.setAttribute('muted', '');
videoPlayer.setAttribute('autoplay', '');
Copy link

Copilot AI Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The autoplay attribute should be conditional based on user preferences or browser policies. Many browsers block autoplay without user interaction, and this may not work reliably across all contexts. Consider implementing a fallback strategy or making autoplay configurable.

Copilot uses AI. Check for mistakes.
@CBenoit CBenoit enabled auto-merge (squash) September 8, 2025 23:40
@CBenoit CBenoit merged commit 0fac6dd into master Sep 8, 2025
41 checks passed
@CBenoit CBenoit deleted the fix/webapp-video-autoplay branch September 8, 2025 23:45
@CBenoit CBenoit mentioned this pull request Sep 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@CBenoit CBenoit CBenoit approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@irvingoujAtDevolution @CBenoit