Skip to content

feat(webapp): add color format selector for VNC session #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CBenoit merged 5 commits into from
Sep 9, 2025
Merged

feat(webapp): add color format selector for VNC session #1475

CBenoit merged 5 commits into from
Sep 9, 2025

Conversation

@RRRadicalEdward
Copy link
Collaborator

@RRRadicalEdward RRRadicalEdward commented Sep 5, 2025

This way, a user can tune the session for their environment (e.g, lower image quality if the network is slow).

Closes https://github.com/Devolutions/IronVNC/issues/908.

@AlexYusiuk
feat(webapp): add color format selector for VNC session
a42336d 
This way a user can tune the session for their environment (e.g, lower image quality if the network is slow).

Closes https://github.com/Devolutions/IronVNC/issues/908.
@github-actions
Copy link

github-actions bot commented Sep 5, 2025

Let maintainers know that an action is required on their side

  • Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

  • Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

  • Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

  • Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

RRRadicalEdward
RRRadicalEdward commented Sep 5, 2025
View reviewed changes
RRRadicalEdward
RRRadicalEdward commented Sep 5, 2025
View reviewed changes
webapp/src/client/app/shared/enums/color-format.enum.ts

enum ColorFormat {
Default = '',
Full = 'rgb888le',
Copy link
Collaborator Author

@RRRadicalEdward RRRadicalEdward Sep 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the available options for color formats

CBenoit
CBenoit reviewed Sep 5, 2025
View reviewed changes
@CBenoit
Copy link
Member

CBenoit commented Sep 9, 2025

LGTM! Needs rebase

@CBenoit CBenoit enabled auto-merge (squash) September 9, 2025 08:24
@CBenoit CBenoit merged commit 9ddf10c into master Sep 9, 2025
39 checks passed
@CBenoit CBenoit deleted the webclient-vnc-component-select-color-format branch September 9, 2025 09:14
@CBenoit CBenoit mentioned this pull request Sep 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CBenoit CBenoit CBenoit approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RRRadicalEdward @CBenoit @AlexYusiuk