Skip to content

fix(pedm): don't error on profile selection if no assignments #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thenextman merged 1 commit into from
Jun 27, 2025
Merged

fix(pedm): don't error on profile selection if no assignments #1398

thenextman merged 1 commit into from
Jun 27, 2025

Conversation

@thenextman
Copy link
Member

@thenextman thenextman commented Jun 27, 2025

If a user has never had a profile assigned, there will be no record of them in the user table.

However, if they try to select a profile, an error is returned. It's better to catch this scenario upfront and just return an empty profile selection and list.

@thenextman thenextman requested a review from a team June 27, 2025 20:33
@thenextman thenextman enabled auto-merge (squash) June 27, 2025 20:33
@github-actions
Copy link

github-actions bot commented Jun 27, 2025

Let maintainers know that an action is required on their side

  • Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

  • Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

  • Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

  • Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

@thenextman thenextman merged commit abe9f7c into master Jun 27, 2025
41 checks passed
@thenextman thenextman deleted the fix-pedm-profile-select-with-no-assignment branch June 27, 2025 22:46
@CBenoit CBenoit mentioned this pull request Jul 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@awakecoding awakecoding awakecoding approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thenextman @awakecoding