Skip to content

fix(webapp): change toolbar activation height #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CBenoit merged 3 commits into from
Jun 20, 2025
Merged

fix(webapp): change toolbar activation height #1390

CBenoit merged 3 commits into from
Jun 20, 2025

Conversation

@RRRadicalEdward
Copy link
Collaborator

@RRRadicalEdward RRRadicalEdward commented Jun 20, 2025 •
edited
Loading

When the webapp is in fullscreen mode, the session toolbar doesn't appear when a user moves the cursor to the top of the screen. It turned out that for some reason, the minimum cursor height is not 0px, but somewhere around 6px. So, I changed the conditions, and now we're checking that the height is less than 10. Now, the session toolbar appears when the user moves the cursor to the top of the screen.

@github-actions
Copy link

github-actions bot commented Jun 20, 2025

Let maintainers know that an action is required on their side

  • Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

  • Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

  • Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

  • Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

@RRRadicalEdward RRRadicalEdward requested a review from CBenoit June 20, 2025 14:06
@RRRadicalEdward RRRadicalEdward self-assigned this Jun 20, 2025
CBenoit
CBenoit approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 💯

@CBenoit CBenoit merged commit 882e757 into master Jun 20, 2025
39 checks passed
@CBenoit CBenoit deleted the webapp-fix-fullscreen-toolbar branch June 20, 2025 15:13
@CBenoit CBenoit mentioned this pull request Jun 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CBenoit CBenoit CBenoit approved these changes

Assignees

@RRRadicalEdward RRRadicalEdward

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RRRadicalEdward @CBenoit @AlexYusiuk