-
Notifications
You must be signed in to change notification settings - Fork 24
feat(webapp): add wheel_speed_factor setting to a VNC and ARD connection forms
#1362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Let maintainers know that an action is required on their side
|
webapp/src/client/app/modules/web-client/ard/web-client-ard.component.ts
Outdated
Show resolved
Hide resolved
CBenoit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I reported the error to DevOps. It may be related to the secrets.
|
@RRRadicalEdward should be fixed if you rebase on master! |
|
@RRRadicalEdward It also occurred to me that this could be a "runtime" option in top bar so the user can adjust even after starting the session. |
We can do it. It will require some refactoring in IronVNC since right now the setting can't be changed after the session is started - https://github.com/Devolutions/IronVNC/blob/master/crates/ironvnc-web/src/session.rs#L807 |
1886b31 to
d6061dc
Compare
|
d6061dc to
6399927
Compare
|
@RRRadicalEdward now this should be fixed for real, I rebased the PR 🙂 EDIT: Apparently it’s still red. I reported to our DevOps team. |
I see, yes. We could add a new event |
6399927 to
1fb05b7
Compare



It looks this way
