Skip to content

Conversation

@RRRadicalEdward
Copy link
Collaborator

@RRRadicalEdward RRRadicalEdward commented May 27, 2025

It looks this way
image

@RRRadicalEdward RRRadicalEdward requested a review from CBenoit May 27, 2025 13:09
@RRRadicalEdward RRRadicalEdward self-assigned this May 27, 2025
@github-actions
Copy link

Let maintainers know that an action is required on their side

  • Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

  • Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

  • Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

  • Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

@RRRadicalEdward
Copy link
Collaborator Author

RRRadicalEdward commented May 27, 2025

CI failed with some weird errors:
image
image

I hope a rerun will help.
EDIT: I didn't help

Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I reported the error to DevOps. It may be related to the secrets.

@CBenoit CBenoit enabled auto-merge (squash) May 27, 2025 13:25
@CBenoit
Copy link
Member

CBenoit commented May 27, 2025

@RRRadicalEdward should be fixed if you rebase on master!

@CBenoit
Copy link
Member

CBenoit commented May 27, 2025

@RRRadicalEdward It also occurred to me that this could be a "runtime" option in top bar so the user can adjust even after starting the session.

@RRRadicalEdward
Copy link
Collaborator Author

@RRRadicalEdward It also occurred to me that this could be a "runtime" option in top bar so the user can adjust even after starting the session.

We can do it. It will require some refactoring in IronVNC since right now the setting can't be changed after the session is started - https://github.com/Devolutions/IronVNC/blob/master/crates/ironvnc-web/src/session.rs#L807

@RRRadicalEdward
Copy link
Collaborator Author

@RRRadicalEdward should be fixed if you rebase on master!

Seems like, there are still some issues
image

@CBenoit CBenoit force-pushed the webapp-wheel-speed-factor branch from d6061dc to 6399927 Compare May 29, 2025 10:53
@CBenoit
Copy link
Member

CBenoit commented May 29, 2025

@RRRadicalEdward now this should be fixed for real, I rebased the PR 🙂

EDIT: Apparently it’s still red. I reported to our DevOps team.

@CBenoit
Copy link
Member

CBenoit commented May 29, 2025

@RRRadicalEdward It also occurred to me that this could be a "runtime" option in top bar so the user can adjust even after starting the session.

We can do it. It will require some refactoring in IronVNC since right now the setting can't be changed after the session is started - https://github.com/Devolutions/IronVNC/blob/master/crates/ironvnc-web/src/session.rs#L807

I see, yes. We could add a new event UiEvent::SetWheelSpeedFactor that is triggered by passing a set_wheel_speed_factor extension to extension_call. That would be a good opportunity to test the design of extension_call.

@RRRadicalEdward RRRadicalEdward force-pushed the webapp-wheel-speed-factor branch from 6399927 to 1fb05b7 Compare May 30, 2025 07:22
@CBenoit CBenoit merged commit e6be3d0 into master May 30, 2025
39 checks passed
@CBenoit CBenoit deleted the webapp-wheel-speed-factor branch May 30, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants