-
Notifications
You must be signed in to change notification settings - Fork 24
feat(webapp): add displayControl checkbox to RDP connection form #1333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webapp): add displayControl checkbox to RDP connection form #1333
Conversation
Let maintainers know that an action is required on their side
|
|
The change is in f5ef013 commit. I branched off #1329, but since that PR is from a fork, I can't set the merge target to that branch. So, we should wait for #1329 to be merged first, and then I will rebase this branch to the new master. After this, we will be able to merge it. But it should be fine review f5ef013 commit as it is now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Let’s merge after the other PR 👍
EDIT: PR merged. Can you rebase your branch?
f5ef013 to
a337b55
Compare
Done |
CBenoit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#1336 must be merged first, and you PR rebased on top of master
a337b55 to
e37dbf3
Compare
No description provided.