Skip to content

Conversation

@RRRadicalEdward
Copy link
Collaborator

No description provided.

@github-actions
Copy link

Let maintainers know that an action is required on their side

  • Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

  • Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

  • Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

  • Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

@RRRadicalEdward
Copy link
Collaborator Author

RRRadicalEdward commented May 13, 2025

The change is in f5ef013 commit. I branched off #1329, but since that PR is from a fork, I can't set the merge target to that branch.

So, we should wait for #1329 to be merged first, and then I will rebase this branch to the new master. After this, we will be able to merge it. But it should be fine review f5ef013 commit as it is now.

Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Let’s merge after the other PR 👍

EDIT: PR merged. Can you rebase your branch?

@RRRadicalEdward RRRadicalEdward force-pushed the web-client-make-display-control-configurable-via-checkbox branch from f5ef013 to a337b55 Compare May 14, 2025 07:05
@RRRadicalEdward RRRadicalEdward changed the title Web client make display control configurable via checkbox feat(webapp): add displayControl checkbox to RDP connection form May 14, 2025
@RRRadicalEdward
Copy link
Collaborator Author

Looking good! Let’s merge after the other PR 👍

EDIT: PR merged. Can you rebase your branch?

Done

Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1336 must be merged first, and you PR rebased on top of master

@CBenoit CBenoit enabled auto-merge (squash) May 14, 2025 07:42
@RRRadicalEdward RRRadicalEdward force-pushed the web-client-make-display-control-configurable-via-checkbox branch from a337b55 to e37dbf3 Compare May 14, 2025 09:24
@CBenoit CBenoit merged commit b056ddf into master May 14, 2025
38 checks passed
@CBenoit CBenoit deleted the web-client-make-display-control-configurable-via-checkbox branch May 14, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants