Skip to content

Conversation

@thenextman
Copy link
Member

The top-level file extension keys may not all exist (in the case of QA, HKEY_CLASSES_ROOT\\.ps1 was not present). Although we check for an empty default value, we don't check for the presence of the top-level key which could cause a null-reference exception and force the installer to roll back.

@thenextman thenextman requested a review from a team March 18, 2025 17:48
@thenextman thenextman enabled auto-merge (squash) March 18, 2025 17:48
@github-actions
Copy link

Let maintainers know that an action is required on their side

  • Add the label release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) when you request a maintainer to cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module)

  • Add the label release-blocker Follow-up is required before cutting a new release if a follow-up is required before cutting a new release

  • Add the label publish-required Please publish libraries (`Devolutions.Gateway.Utils`, OpenAPI clients, etc) when you request a maintainer to publish libraries (Devolutions.Gateway.Utils, OpenAPI clients, etc.)

  • Add the label publish-blocker Follow-up is required before publishing libraries if a follow-up is required before publishing libraries

@thenextman thenextman added the release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) label Mar 18, 2025
@github-actions
Copy link

Maintainer action requested

Author requested a new release to be cut.

cc @CBenoit

Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@thenextman thenextman merged commit d36978e into master Mar 18, 2025
43 checks passed
@thenextman thenextman deleted the fix-exp-command-reg-nre branch March 18, 2025 21:33
@CBenoit CBenoit changed the title fix(installer): resolve potential null reference installing PEDM shell extension fix(agent-installer): resolve potential null reference installing PEDM shell extension Mar 18, 2025
@CBenoit CBenoit removed the release-required Please cut a new release (Devolutions Gateway, Devolutions Agent, Jetsocat, PowerShell module) label Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants