fix(web): fix this.lastSentClipboardData being null
#992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```js await this.remoteDesktopService.onClipboardChanged(...) ``` Consumes the clipboard data we pass, so we need to clone the data, to prevent `this.lastSentClipboardData` being null.
4ca8e25 to
e44d4dc
Compare
Coverage Report 🤖 ⚙️Past: New: Diff: +0.02% [this comment will be updated automatically] |
Member
|
I think a better approach is to not consume the data in the callback, and to expose a more JavaScript friendly API in this case. How does that sound to you? |
Collaborator
Author
Make sense. Let me do it |
Collaborator
Author
Done. Could you check it out? |
CBenoit
reviewed
Sep 24, 2025
web-client/iron-remote-desktop/src/services/clipboard.service.ts
Outdated
Show resolved
Hide resolved
CBenoit
reviewed
Sep 24, 2025
CBenoit
reviewed
Sep 24, 2025
CBenoit
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consumes the clipboard data we pass, so we need to clone the data to prevent
this.lastSentClipboardDatafrom being null.