Skip to content

feat: support annotations#91

Merged
aabouzaid merged 3 commits intoDevOpsHiveHQ:mainfrom
gahaney:add-annotation-support
Sep 7, 2025
Merged

feat: support annotations#91
aabouzaid merged 3 commits intoDevOpsHiveHQ:mainfrom
gahaney:add-annotation-support

Conversation

@gahaney
Copy link
Copy Markdown
Contributor

@gahaney gahaney commented Aug 26, 2025

Add support for custom annotations to the outputted configmap and secret manifests. We have a use case for needing to use the suffix hash generator and options for argocd, like so:

output:
  annotations:
    kustomize.config.k8s.io/needs-hash: "true"
    argocd.argoproj.io/sync-options: PruneLast=true
  format: configmap

Definitely not a go developer though, so welcome any feedback. This works well when I built it locally.

@gahaney gahaney requested a review from aabouzaid as a code owner August 26, 2025 18:12
@aabouzaid aabouzaid changed the title add annotation support feat: support annotations Sep 2, 2025
@aabouzaid
Copy link
Copy Markdown
Collaborator

aabouzaid commented Sep 2, 2025

@gahaney Thanks for the contribution:raised_hands:
LGTM, we just need a unit test for it.

@gahaney
Copy link
Copy Markdown
Contributor Author

gahaney commented Sep 5, 2025

@gahaney Thanks for the contribution:raised_hands: LGTM, we just need a unit test for it.

Added tests for secret + configmap and updated readme.

@aabouzaid aabouzaid force-pushed the add-annotation-support branch from a1353bc to 53e88de Compare September 6, 2025 22:56
@aabouzaid aabouzaid force-pushed the add-annotation-support branch from 53e88de to 01ee851 Compare September 6, 2025 23:04
@aabouzaid aabouzaid added the enhancement New feature or request label Sep 6, 2025
@aabouzaid
Copy link
Copy Markdown
Collaborator

aabouzaid commented Sep 7, 2025

For the record, I made the following tiny fixes:

  • Disabled exportloopref, as it has a bug fix that was never released for the golint 1.x version.
  • Disabled dupl for the unit test.
  • Fixed the cache GHA version.

The issue about building artifacts in the CI is irrelevant.

Thanks @gahaney for your work 🙌

@aabouzaid aabouzaid merged commit 88b5b0f into DevOpsHiveHQ:main Sep 7, 2025
5 of 7 checks passed
@github-actions github-actions Bot mentioned this pull request Nov 22, 2024
Merged
@gahaney
Copy link
Copy Markdown
Contributor Author

gahaney commented Sep 19, 2025

@aabouzaid looks like the release job failed to upload?

@aabouzaid
Copy link
Copy Markdown
Collaborator

aabouzaid commented Sep 22, 2025

@gahaney, the release PR still needs to be merged. I will do it this week.

@aabouzaid
Copy link
Copy Markdown
Collaborator

aabouzaid commented Oct 4, 2025

@gahaney Released 2.2.0 ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aabouzaid aabouzaid Awaiting requested review from aabouzaid aabouzaid is a code owner

Assignees

@gahaney gahaney

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gahaney @aabouzaid